Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

View Change

5 comments:

• File ni845x_spi.c:

  • Patch Set #1, Line 188: strtol

    +1

    Done

  • Patch Set #1, Line 483: const

    Unrelated change?

    Yepp, submitting it an another PR.

  • Patch Set #1, Line 556: CS_number = CS_str[0] - '0';

    Interesting, thank you very much!

    Done

  • Patch Set #1, Line 558: strlen(CS_str)

    Note that the alternative approach proposed below avoids the use-after-free bug.

    Done

  • Patch Set #1, Line 556:

    CS_number = CS_str[0] - '0';
    		free(CS_str);
    		if (strlen(CS_str) > 1 || 7 < CS_number) {
    			msg_perr("Only CS 0-7 supported\n");
    			return 1;
    		}
    

    It's simpler, sounds good.

    Done

To view, visit change 56637. To unsubscribe, or for help writing mail filters, visit settings.