Attention is currently required from: Simon Buhrow, Thomas Heijligen.

View Change

2 comments:

• File sfdp.c:

  • Patch Set #9, Line 80: add

    This function fills the erasers of `chip`. So it cannot rely on existing
    erasers in there.

• File spi.c:

  • Patch Set #9, Line 102: }

    I'm sorry. I did not realize until now that it's impossible to
    implement this function with the `function_opcode_list` for
    spi_get_opcode_from_erasefn(). If there is no 1:1 mapping (for
    this list), it just can't work. The only use of this function
    is for spi25 chips and it needs exactly the signature that it
    had so far.

    So again, I think it's best to leave spi_get_erasefn_from_opcode()
    in `spi25.c`, with the original list. We can surely rename it to
    spi25_* to avoid further confusion (it's just not as generic as
    the spi_ prefix suggests; doesn't have to be).

To view, visit change 67354. To unsubscribe, or for help writing mail filters, visit settings.