View Change

4 comments:

• File jlink_spi.c:

  • Patch Set #1, Line 130:

    Do not free it here or set `buffer = NULL;`. Otherwise we'd […]

    Ping?

    Also, `buffer_size` should be set to zero too if we keep the free().
    Btw., it would all get less complex if we'd just malloc()/free() on
    every call, w/o the global buffer.

• File jlink_spi.c:

  • Patch Set #2, Line 191: /* TODO: Use kHz for speed and update manual! */

    already obsolete?

  • Patch Set #2, Line 195: && strlen(arg) > 0

    Why check the strlen? if it's 0, the user literally typed `:spispeed=`
    without a value. Why allow that?

  • Patch Set #2, Line 344: dev

    Isn't this `dev` (as part of `devs`) free'd yet?

To view, visit change 28087. To unsubscribe, or for help writing mail filters, visit settings.