Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk.

View Change

1 comment:

• File include/flash.h:

  • Patch Set #8, Line 624:

    	flashrom_progress_callback_v2 *progress_callback;
    	struct flashrom_progress progress_state;
    	struct stage_progress stage_progress[FLASHROM_PROGRESS_NR];
    	/* deprecated, do not use */
    	flashrom_progress_callback *deprecated_progress_callback;
    	struct flashrom_progress *deprecated_progress_state;
    

    That makes sense, but I think that means the old function is currently inconsistent in its behavior […]

    I made an attempt (added lines 90-97 in libflashrom.c), that would ensure only one callback can be registered, whichever one was registered first.

    It was not easy to come up with a clear message, but I tried :)

    Does this look like something that you meant ?

To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.