Attention is currently required from: Aarya, Edward O'Callaghan, Peter Marheine.
4 comments:
Patchset:
Aarya, I am very happy to see you here again! :) I added few comments , but I will look once more later. Thank you for working on this!
Commit Message:
Maybe you can add link to the ticket in the commit message
https://ticket.coreboot.org/issues/416
File include/programmer.h:
Patch Set #1, Line 167: enum is_laptop {
I think, it's better to merge two patches together. What do you think?
This enum by itself doesn't do much, but the next patch fully implements its purpose. I would prefer that in the same patch.
enum is_laptop {
NO,
YES,
UNKNOWN,
};
My first thought was that UNKNOWN would be a more intuitive default value. But then, I understand that this order keep the same order as it was with numbers (0 default was equivalent to NO).
Does anyone has thoughts on better default value, NO or UNKNOWN?
To view, visit change 83833. To unsubscribe, or for help writing mail filters, visit settings.