Patch set 4:Code-Review +1

View Change

4 comments:

• File at45db.c:

  • Patch Set #4, Line 466: flash->mst->spi.max_data_write - 4

    Could this subtraction possibly underflow? Asking since there is the max_data_write > 0 check below.

• File dummyflasher.c:

  • Patch Set #4, Line 234: %i

    Should be %u now

  • Patch Set #4, Line 270: %i

    Should be %u now

• File print.c:

  • Patch Set #4, Line 331: %d

    Should be %u now

To view, visit change 30409. To unsubscribe, or for help writing mail filters, visit settings.