Attention is currently required from: Felix Singer, Edward O'Callaghan, Alex Badea.
Patch set 5:Code-Review +2
6 comments:
Patchset:
Thanks for the detailed answers. From my side it looks nearly fine. I've added a few nits.
Beside that I've ordered one of those controllers and will test it in the next days.
Edward, do you see something missing?
File asm106x.c:
Patch Set #3, Line 35: {PCI_VENDOR_ID_ASMEDIA, 0x0612, OK, "ASMedia", "ASM106x"},
Ack
Ok, I'm fine with it. If someone has a chip with the other PCI-Id we can clarify it then.
File asm106x.c:
Please use `inttype.h` macros here for fixed length integer. We have problems with those on some compilers and a proper syntax for them comes first with c23. So for uint8_t as hex it gets
```
msg_pdbg2("asm106x status %#02"PRIx8" tries %d\n", val, timeout);
```
Patch Set #5, Line 57: msg_pdbg("asm106x timed out, ctrl 0x%02x\n", val);
Same here `... ctrl %#02"PRIx8"\n"`
Patch Set #5, Line 81: msg_pdbg2("asm106x write 0x%08x chunk %u\n", val, chunk);
`write %#08"PRIx32" chunk`
Patch Set #5, Line 99: msg_pdbg2("asm106x read 0x%08x chunk %u\n", val, chunk);
`read %#08"PRIx32" chunk`
To view, visit change 73037. To unsubscribe, or for help writing mail filters, visit settings.