Patch Set 1:

Patch Set 1: Code-Review-1

Please don't. This breaks git blame and IMO makes the file harder to read.
None of the meson files use tabs, and I'd rather have a mixed tabs/spaces style there.

Well, git blame on this rather recent part of the code isn't too critical. What about the reordering of flashchips.c, which also broke git blame? In any case, one can checkout the parent of the offending commit and run git blame on that.

With regard to tabs, would this be better if done with spaces instead? It would make the lines shorter.

You're right, the flashchips.c reordering should never have happened. Unfortunately, I didn't notice it before it was committed, otherwise I would have complained.
I've done too much blame-chasing in my time as flashrom maintainer and would rather not repeat that ever again. When you're trying to track down a bug, the age of the code is less relevant than the number of no-op commits you have to wade through.

With regard to reformatting, both a reformat with tabs and a reformat with spaces do not make much sense. Once a new programmer with a longer name than expected comes along, someone will reformat the whole file again. And again. Not having this aligned is actually a feature, because then you don't have to realign it.

View Change

To view, visit change 38662. To unsubscribe, or for help writing mail filters, visit settings.