Attention is currently required from: foss@volatilesystems.org, Angel Pons.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Thought it might have been better to wait for clarity on the commit message before doing that, but I […]

    Usually the rule of thumb is: if you mark comments as resolved, you need to upload new patchset which demonstrates that you indeed resolved the comments. Otherwise how do we know what you have in local repo? :)
    Gerrit allows to view "incremental" diffs between patchsets, which can be very handy.
    Also it is entirely normal to resolve some of the comments (not all of them), and for the remaining ones ask for clarification, not a problem!

To view, visit change 69309. To unsubscribe, or for help writing mail filters, visit settings.