Patch Set 17:

(19 comments)

First time I looked through all the code. I know it's
already been lying around for more than a year, sorry
for that.

It looks nearly ready, although I added some serious
comments. Also, there is still a lot of CamelCase. And
generally, we try to follow the coding style of the
Linux kernel. There is a nice tool to help with that
(checkpatch.pl [1]). That is, if you have perl installed.
I don't use it myself, but let me try...

    ./checkpath.pl --no-tree --max-line-length=112 --file ni845x_spi.c

The first warning is spurious, but the errors should be
checked. And the other warnings might give some nice
hints.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl

Thanks for the review Nico, no worries for the timing, it is better later than never ;).

Also thanks for the checkpatch hint, it revealed a lot of things!

View Change

18 comments:

To view, visit change 25683. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549
Gerrit-Change-Number: 25683
Gerrit-PatchSet: 19
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Márton Miklós <martonmiklosqdev@gmail.com>
Gerrit-CC: Stefan T <stefan.tauner@gmx.at>
Gerrit-Comment-Date: Wed, 10 Jul 2019 21:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment