Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
nicintel_eeprom: Delete extra parentheses from if condition

BUG=185191942
TEST=builds

Change-Id: I068bd227668a79f14e38e703a5a49db18d5de8c7
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56820
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
---
M nicintel_eeprom.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nicintel_eeprom.c b/nicintel_eeprom.c
index b5f2050..430a980 100644
--- a/nicintel_eeprom.c
+++ b/nicintel_eeprom.c
@@ -466,7 +466,7 @@
return 1;

nicintel_pci = dev;
- if ((dev->device_id != UNPROG_DEVICE)) {
+ if (dev->device_id != UNPROG_DEVICE) {
uint32_t eec = pci_mmio_readl(nicintel_eebar + EEC);

/* C.f. 3.3.1.5 for the detection mechanism (maybe? contradicting

To view, visit change 56820. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I068bd227668a79f14e38e703a5a49db18d5de8c7
Gerrit-Change-Number: 56820
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged