Attention is currently required from: Nico Huber, Martin L Roth, Edward O'Callaghan, Anastasia Klimchuk.

Patch set 2:-Code-Review

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    Yes this is also my understanding (as Martin explained): this patch gives a way to override "warning […]

    I think what Nico is trying to say is that the Makefile already enables WARNERROR by default and so this is redundant to it. We can just remove it from the shell script.

    So we can change the line to this:

      make CONFIG_EVERYTHING=yes

    And we can still configure WARNERROR:

      WARNERROR=no ./test_build.sh

    Tested on my system and it works. WARNERROR is set to "no" then.

To view, visit change 62745. To unsubscribe, or for help writing mail filters, visit settings.