Patch Set 8:

Patch Set 8:

Oops, this introduced a bug: the SFDP entry is no longer at the end of flashchips.c, so probing on a SFDP-capable Winbond chip results in added noise (flashrom says things about an unknown chip, and then has two definitions for the same chip).

It's trivial to fix, but it might affect the codebase merging.

Oops indeed. I'll send a patch to put it back at the end.

I have sent for review.

View Change

To view, visit change 33931. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I75a99583592526f60ba5264e92391bf8b1213b20
Gerrit-Change-Number: 33931
Gerrit-PatchSet: 8
Gerrit-Owner: Alan Green <>
Gerrit-Reviewer: Alan Green <>
Gerrit-Reviewer: David Hendricks <>
Gerrit-Reviewer: Edward O'Callaghan <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Angel Pons <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Fri, 23 Aug 2019 00:15:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment