Attention is currently required from: Chen, Thomas Heijligen, Alexander Goncharov.
Patch set 5:Code-Review +2
View Change
1 comment:
File jlink_spi.c:
Patch Set #3, Line 160: tms_buffer
When CS is connected to TMS, TMS should remain low(nCS=0, CS=1) upon transmission.
Chen, thanks for adding comment to the code, that's useful.
Does this answer your question Joursoir? don't want to resolve without checking with you.
From me a question: I understand you tested with `cs=TMS` right? Would it be possible for you to test a default case too? Thanks!
To view, visit change 75011. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1
Gerrit-Change-Number: 75011
Gerrit-PatchSet: 5
Gerrit-Owner: Chen <c@jia.je>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Chen <c@jia.je>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Thu, 11 May 2023 23:31:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Chen <c@jia.je>
Comment-In-Reply-To: Alexander Goncharov <chat@joursoir.net>
Gerrit-MessageType: comment