Attention is currently required from: Brian Norris.

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

View Change

2 comments:

• Commit Message:

  • Patch Set #2, Line 9:

    It's not valid to separately check the major and minor versions. The
    proper minor check would be something like:
    
      if (fmap->ver_major == FMAP_VER_MAJOR &&
          fmap->ver_minor > FMAP_VER_MINOR)
    

    Brian, I like this idea! Maybe you can move the code from commit message into the code? :)

    I looked into the chromiumos patch you linked, it still checks both major and minor versions.
    The diff I see is that the check is more strict (both major and minor version expected to be exact equal) while initial fmap.c checks that the versions are not greater than.

    I can agree to make the check more strict, but I don't see why checking minor version has to be dropped, I think it can stay?

    I admit I haven't looked into cbfstool code, is there a way you can link a relevant piece? (if you think it's useful. if not then not)

• Patchset:

  • Patch Set #2:

    Hi Anastasia: […]

    Sure, I am having a look! I added one comment.
    I didn't realise this patch is hanging without attention, sorry

To view, visit change 79060. To unsubscribe, or for help writing mail filters, visit settings.