Attention is currently required from: Sergii Dmytruk.
4 comments:
Patchset:
Just out of curiosity I ran the test case from here https://review.coreboot.org/c/flashrom/+/84614/1..3//COMMIT_MSG#b19 but with added progress and freq param. That other patch is not about progress indicator, but it is a deep dive into erase/write logic, and in the test case there are various areas which need/need not to be written or erased.
The progress is shown! Read and write eventually get to 100, erase did not (only got up to 50), I guess because only selective regions were needed to erase.
Not blocking this patch, but it was interesting to check. It seems there is a room for improvement, but as I said I think not blocking this patch
File flashrom.c:
Patch Set #13, Line 1270: // FIXME: round up to granularity?
I think `get_next_write` limits length to not try to suggest writing more data then there is. […]
Okay so I will close this (and the other one). I removed FIXMEs, is this fine?
Patch Set #13, Line 1281: // FIXME: should be rounded up to page size?
It does take granularity into account so maybe it's fine as is, assuming that regions never cross bo […]
Acknowledged
Patch Set #13, Line 1463: // TODO: use erase_layout?
I want to try to do this, leaving this as comment
Actually not, at this stage erase_layout is not useful: because it is only created but not initialised and more importantly, not processed for which erase blocks are selected for being run. There is no info for progress in erase_layout at this stage.
To view, visit change 84439. To unsubscribe, or for help writing mail filters, visit settings.