Attention is currently required from: Nico Huber, Subrata Banik, Edward O'Callaghan, Angel Pons.

4 comments:

Commit Message:
- Patch Set #6, Line 9: This patch add support for SPI HW sequencing 64KB erase operation based
  Excuse my ignorance, but could you start with an introduction of the functionality. Is that a feature of new devices?
- Patch Set #6, Line 9:
```
based
on erase_block size and `only_4k` flag is not set
```
  I do not know the whole code, but where is the `only_4k` done in the diff?
- Patch Set #6, Line 13: TEST=Able to perform SPI erase operation on brya.
  Are they faster now?

File ichspi.c:

Patch Set #6, Line 1476:

if (erase_block == 64 * KiB)
		erase_cycle = HSFC_CYCLE_64K_ERASE;
	else
		erase_cycle = HSFC_CYCLE_4K_ERASE;

Use ternary operator?

    erase_cycle = (erase_block == 64 * KiB) ? HSFC_CYCLE_64K_ERASE : HSFC_CYCLE_4K_ERASE;

To view, visit change 62870. To unsubscribe, or for help writing mail filters, visit settings.