Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
View Change
1 comment:
Commit Message:
Patch Set #26, Line 10:
Chips I wasn't able to test were just
checked against the datasheets.
Could a EM100 be leveraged here?
I just tried it, it would have been a great way to test but it appears that SR2 commands are being intrepreted incorrectly, e.g.
0x35 should be read sr2 and 0x31 should be write sr2.
```
em100 -c GD25Q64 --stop -t --start`
...
0x35 - enter quad I/O mode
...
0x31 - unknown command
```
To view, visit change 62214. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7f3d4c4148056098a845b5c64308b0333ebda395
Gerrit-Change-Number: 62214
Gerrit-PatchSet: 26
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Fri, 25 Mar 2022 05:51:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment