Attention is currently required from: Robert Zieba, Nico Huber, Diana Zigterman, Edward O'Callaghan, Anastasia Klimchuk, Karthik Ramasubramanian.
View Change
1 comment:
File raiden_debug_spi.c:
Patch Set #2, Line 989: if (rsp_config.packet_size == 4 &&
is packet size in bytes or words? Can we use sizeof() instead of a magic number? Can you update the comment to be more clear about the size of the packet?
To view, visit change 62909. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib1e8383baa9c3ea41ab1079af12e3dc8cdff90ae
Gerrit-Change-Number: 62909
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Zieba <robertzieba@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Diana Zigterman <dzigterman@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Jon Murphy <jpmurphy@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Eric Peers <epeers@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Robert Zieba <robertzieba@google.com>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Diana Zigterman <dzigterman@google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 16:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment