Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41608 )
Change subject: raiden_debug_spi.c: Add transfer context states ......................................................................
Patch Set 21:
(5 comments)
https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG@7 PS13, Line 7: Adds
Add
Done
https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG@9 PS13, Line 9: Adds
Add
Done
https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG@14 PS13, Line 14: Adds
Add
Done
https://review.coreboot.org/c/flashrom/+/41608/13/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41608/13/raiden_debug_spi.c@149 PS13, Line 149:
There's pros and cons to using either spaces or tabs for alignment. […]
.
https://review.coreboot.org/c/flashrom/+/41608/13/raiden_debug_spi.c@158 PS13, Line 158: We too much data.
Yes, it should be 'The host received more data than can fit in read buffer'
Fixed in next CL where this was moved to.