Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41608 ) Change subject: raiden_debug_spi.c: Add transfer context states ...................................................................... Patch Set 21: (5 comments) https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG@7 PS13, Line 7: Adds
Add Done
https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG@9 PS13, Line 9: Adds
Add Done
https://review.coreboot.org/c/flashrom/+/41608/13//COMMIT_MSG@14 PS13, Line 14: Adds
Add Done
https://review.coreboot.org/c/flashrom/+/41608/13/raiden_debug_spi.c File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/41608/13/raiden_debug_spi.c@149 PS13, Line 149:
There's pros and cons to using either spaces or tabs for alignment. […] .
https://review.coreboot.org/c/flashrom/+/41608/13/raiden_debug_spi.c@158 PS13, Line 158: We too much data.
Yes, it should be 'The host received more data than can fit in read buffer' Fixed in next CL where this was moved to.
-- To view, visit https://review.coreboot.org/c/flashrom/+/41608 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic6eea82ffc604ec56278f7aaa0deafe0cf75973c Gerrit-Change-Number: 41608 Gerrit-PatchSet: 21 Gerrit-Owner: Brian Nemec <bnemec@google.com> Gerrit-Reviewer: Brian Nemec <bnemec@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 20 Jul 2020 03:58:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Brian Nemec <bnemec@google.com> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment