Youness Alaoui posted comments on this change.

View Change

Patch set 8:Code-Review +2

The RPCI fix is pushed here :
Now all we need is for this patch to set the 'pacc' variable and
restore it at the end of the function.

Um, I don't see why I have to wait for a seven years old bug to get
fixed before I add another chipset... also, if we fix it here and
in your patch, we'll lose the explicit information that the changes
are related (e.g. if anyone will ever fix the rpci interface he'll
more likely miss to remove the workaround here).

Humm... you're right, the rpci bug is unrelated to skylake, I just see it only with skylake because that's the one that I build manually, I also associated it with this patch until I figured out the bug was from rpci.
The patch looks good so I +2. I've half reviewed the ichspi one, but I'm not done yet.

To view, visit change 18925. To unsubscribe, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I000819aff25fbe9764f33df85f040093b82cd948
Gerrit-Change-Number: 18925
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber <>
Gerrit-Reviewer: David Hendricks <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: Stefan Reinauer <>
Gerrit-Reviewer: Stefan Tauner <>
Gerrit-Reviewer: Youness Alaoui <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-Comment-Date: Thu, 27 Jul 2017 19:56:04 +0000
Gerrit-HasComments: No