Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

7 comments:

• File cli_classic.c:

  • Patch Set #3, Line 691: bool

    const bool

    Done

  • Patch Set #3, Line 695: |

    nit: missing space before `|` […]

    Done

• File writeprotect.h:

  • Patch Set #3, Line 21: #define MAX_WP_RANGES 128

    Why 128?

    I chose 128 arbitrarily, but it can be bounded by the number of range-related bits on a chip. The most I've seen is 6 (3BP+TB+SEC+CMP) so 64 would be sufficient.

  • Patch Set #3, Line 31: uint32_t

    Missing header include

    Done - through flash.h. I can add explicit #includes for stdint.h and stdbool.h too though.

  • Patch Set #3, Line 36: bool

    Missing header include

    Done

  • Patch Set #3, Line 38: size_t

    Missing header include

    Done

• File writeprotect.c:

  • Patch Set #3:

    I find it hard to evaluate an interface without seeing its implementation. […]

    That seems reasonable, I can just comment out the calls in cli_classic.c. I'll wait to see what others think though.

To view, visit change 58474. To unsubscribe, or for help writing mail filters, visit settings.