Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Angel Pons.

View Change

1 comment:

• File ite_ec.c:

  • Patch Set #10, Line 781:

    
    	if (!ec_write_reg(0xf9, 0x20, EC_MAX_STATUS_CHECKS) ||
    	    !ec_write_reg(0xfa, 0x02, EC_MAX_STATUS_CHECKS) ||
    	    !ec_write_reg(0xfb, 0x00, EC_MAX_STATUS_CHECKS) ||
    	    !ec_write_reg(0xf8, 0xb1, EC_MAX_STATUS_CHECKS)) {
    		msg_perr("Unable to initialize controller.\n");
    		return 1;
    

    how could this ever work? o.O https://review.coreboot.org/c/flashrom/+/55714/4/acpi_ec.c#95

    any idea what this is doing?

To view, visit change 55715. To unsubscribe, or for help writing mail filters, visit settings.