Attention is currently required from: Angel Pons, Brian Norris, Hsuan-ting Chen, Thomas Heijligen.
View Change
1 comment:
Patchset:
Patch Set #5:
More references here: […]
Hsuan-ting, thanks for lots of information! I read all of this, I like information :)
As for me, I am fine with "open / close" or also would be fine with "remove / insert" (I think "restore" is confusing). I also don't think we need "use the designated command", which command?
Out of people on the patch, Brian and Hsuan-ting are currently active users of flashrom_tester.
Brian, what do you think? Let's decide.
"open / close" or "remove / insert" ?
3 people who are not currently active users of flashrom_tester agree with "open / close" :)
To view, visit change 82083. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270
Gerrit-Change-Number: 82083
Gerrit-PatchSet: 5
Gerrit-Owner: Brian Norris <briannorris@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Evan Benn <evanbenn@gmail.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Brian Norris <briannorris@chromium.org>
Gerrit-Attention: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Wed, 01 May 2024 11:02:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <roccochen@google.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment