Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• Commit Message:

  • Patch Set #4, Line 8:

    ```
    The following describes the two mechanisms of testing done for flash chip operations.

    BUG=?
    TEST=none
    ```

• File tests/chip.c:

  • Patch Set #4, Line 30:

    Importantly
     * there are two types of tests here, corresponding to two ways of
     * emulating a chip:
    

    This is all very difficult and verbose sentence to parse. I think you are really only just saying the following short sharp points.

    ```
    Two flash chip test variants are used:

    i ) Mock chip state backed by `g_chip_state` and,
    ii) Mock chip operations backed by `dummyflasher` emulation.
    ```

    It is odd to have this comment juxtaposition next to to `g_chip_state` as only part (i) is relevant to it. A better position would be after the license as a preamble to the files content.

To view, visit change 59238. To unsubscribe, or for help writing mail filters, visit settings.