Patch Set 3: Code-Review+1

(1 comment)

View Change

1 comment:

• File cli_classic.c:

  • Patch Set #3, Line 430:

    	if ((read_it | write_it | verify_it) && check_filename(filename, "image")) {
    		cli_classic_abort_usage();
    	}
    	if (layoutfile && check_filename(layoutfile, "layout")) {
    		cli_classic_abort_usage();
    	}
    	if (fmapfile && check_filename(fmapfile, "fmap")) {
    		cli_classic_abort_usage();
    	}
    	if (referencefile && check_filename(referencefile, "reference")) {
    		cli_classic_abort_usage();
    	}
    

    are we removing this more "defensive" coding style on purpose?

    It was requested in the previous review? I don't think this is defensive much here as there isn't any resource management to be had on these branches that validate arg combinatorics.

To view, visit change 35611. To unsubscribe, or for help writing mail filters, visit settings.