Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk, Peter Marheine. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33542 ) Change subject: layout: Introduce layout_next() ...................................................................... Patch Set 7: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/33542/comment/0939b4b4_83a5a2c7 PS3, Line 7: layout: Introduce layout_next() : : Also, a `layout.c` internal version _layout_next()
Yes, thank you, definitely better! Just commit message left (still old one). Done
File layout.c: https://review.coreboot.org/c/flashrom/+/33542/comment/a45179ff_4bf7efa3 PS3, Line 44: static struct romentry *_layout_next(
Nico is correct, one is const while the other isn't. […] Done?
File libflashrom.c: https://review.coreboot.org/c/flashrom/+/33542/comment/868a29f0_fd3fe0a7 PS2, Line 351: chip_entry = layout_next(&chip_layout->base, chip_entry); : dump_entry = layout_next(&dump_layout.base, dump_entry);
Anything to do about it? I could add more pointers, but I don't think […] Ping
-- To view, visit https://review.coreboot.org/c/flashrom/+/33542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I284958471c61344d29d92c95d88475065a9ca9aa Gerrit-Change-Number: 33542 Gerrit-PatchSet: 7 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Daniel Campello <campello@chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Daniel Campello <campello@chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Attention: Peter Marheine <pmarheine@chromium.org> Gerrit-Comment-Date: Sat, 19 Jun 2021 15:01:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org> Gerrit-MessageType: comment