Attention is currently required from: Keith Hui, Angel Pons, Light, Anastasia Klimchuk.
View Change
1 comment:
Patchset:
Patch Set #1:
`INB(0x80)` reads a byte from I/O port 0x80. […]
Correct. The read is used as a small delay between polling the SMBus controller for when the command is done. I probably copied it from other similar functions within flashrom. The assignment (which this patch tries to remove) is to make sure compiler doesn't warn; we don't care about what is read from 0x80. If it builds still afterwards, it's fine by me.
To view, visit change 62761. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc
Gerrit-Change-Number: 62761
Gerrit-PatchSet: 4
Gerrit-Owner: Light <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Keith Hui <buurin@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Idwer Vollering <vidwer@gmail.com>
Gerrit-CC: Keith Hui <buurin@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Keith Hui <buurin@gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Light <aarya.chaumal@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Mon, 14 Mar 2022 11:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Light <aarya.chaumal@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment