Nico Huber merged this change.

View Change

Approvals: Nico Huber: Verified; Looks good to me, approved Christian Walter: Looks good to me, but someone else must approve
layout: Increase max rom layout size

When trying to flash a single FMAP region on VBOOT enabled boards the
default of 32 entries is to small to store all regions. Flashrom will
bail out with "Cannot add fmap entries to layout - Too many entries."

Increase the maximum rom layout size to 128 to support complex FMAPs.

Tested on coreboot's UP/squared mainboard using SF600.
With this patch it's possible to update a single FMAP region.

Change-Id: I68084b08f7b35a162b5f2d3109d82a8b63c194ff
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/34025
Tested-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Christian Walter <christian.walter@9elements.com>
---
M layout.h
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/layout.h b/layout.h
index 53a20d6..8e4eb13 100644
--- a/layout.h
+++ b/layout.h
@@ -33,7 +33,7 @@
#define PRIxCHIPOFF "06"PRIx32
#define PRIuCHIPSIZE PRIu32

-#define MAX_ROMLAYOUT 32
+#define MAX_ROMLAYOUT 128

struct romentry {
chipoff_t start;

To view, visit change 34025. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I68084b08f7b35a162b5f2d3109d82a8b63c194ff
Gerrit-Change-Number: 34025
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-MessageType: merged