Angel Pons submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
ichspi: Do not attempt to map physical memory for hwseq

ICH hwseq does not need to actually mmap flash, and this fails for
flash chips >16 MB, since only the top 16 MB is mapped into the address
space.

Test: Read and write flash on ICH hwseq with 32 MB flash chip.

Change-Id: Ie698071c3181e988f10b750b0e50c9700efaa1a3
Signed-off-by: Jonathon Hall <jonathon.hall@puri.sm>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68090
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M ichspi.c
1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/ichspi.c b/ichspi.c
index 7e7967e..aefbe2f 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -1794,8 +1794,6 @@
};

static const struct opaque_master opaque_master_ich_hwseq = {
- .map_flash_region = physmap,
- .unmap_flash_region = physunmap,
.max_data_read = 64,
.max_data_write = 64,
.probe = ich_hwseq_probe,

To view, visit change 68090. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie698071c3181e988f10b750b0e50c9700efaa1a3
Gerrit-Change-Number: 68090
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged