Patch Set 6: Code-Review+1

(1 comment)

For upstream, you should probably also update cli_classic_usage() and the man page. For this patch I think adding --flash-size should be sufficient, but let's see what others have to say about this approach.


View Change

1 comment:

To view, visit change 35592. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8f002f3b2012aec4d26b0e81456697b9a5de28d6
Gerrit-Change-Number: 35592
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan <>
Gerrit-Reviewer: Alan Green <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: David Hendricks <>
Gerrit-Reviewer: Edward O'Callaghan <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Stefan Reinauer <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Fri, 04 Oct 2019 04:28:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <>
Comment-In-Reply-To: David Hendricks <>
Gerrit-MessageType: comment