Attention is currently required from: Daniel Campello, Angel Pons.
1 comment:
Patchset:
I don't understand the concern that goes away when "filename check would move from read_flash_to_file into do_read". In both cases (with and without CB:59291) the filename in do_read should be optional
I don't think filename in do_read *should* be optional, but at least I can agree it *can* be optional in do_read. This patch, however, makes it optional in read_flash_to_file, which is one level lower and IMO creates potential source of errors for other use cases.
Since this CL is solving a bug I believe it should go on first
Yes this patch is solving a bug, but ... the bug was introduced 7 months ago, and no one noticed. This is ofc not an excuse to have broken code, but I think we can afford to spend few extra days to do the right thing. CB:59291 is pretty much ready, and tested, so there is not much risk in rebasing on top of it.
Otherwise I'm not strongly opposed with rebasing.
This is awesome! Thank you Daniel! Let's rebase :)
To view, visit change 59921. To unsubscribe, or for help writing mail filters, visit settings.