Attention is currently required from: Edward O'Callaghan, Evan Benn, Peter Marheine.
Patch set 2:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #2:
I support removing this, we get weird diffs with the `--output` option.
`log()` calls are included in both stdout and the log file, but `println()!` is only included in stdout. Unix style redirect is more reliable for now.
To view, visit change 71773. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5eab8169644a16ba31b203e8607853c459f92978
Gerrit-Change-Number: 71773
Gerrit-PatchSet: 2
Gerrit-Owner: Evan Benn <evanbenn@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Evan Benn <evanbenn@google.com>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Thu, 12 Jan 2023 00:11:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment