Attention is currently required from: Edward O'Callaghan, Stefan Reinauer.
7 comments:
Patchset:
This is awesome! Thank you so much for the patch!
File flashchips.c:
* Temporarily, this file is sorted alphabetically by vendor and name to
* assist with merging the Chromium fork of flashrom.
Can we remove this comment by now? (maybe in a separate patch). the most confusing part is "temporarily".
Patch Set #5, Line 34: internal_
i understand there is no technical need, but i did it to make it more obvious that it is not coming […]
I agree that "internal" almost always means internal programmer. It is flashromspeak :)
It is certainly not coming from the outside because it is static.
I am not sure a prefix needed, if you think it is really needed then maybe "supported_flashchips", but this doesn't add much readability.
Maybe let's try without prefix?
Patch Set #5, Line 20844: get_flashchips(void)
sure, but that would be more complex.
Where would the caller get the pointer to flashchip db? and why the caller needs to have the pointer? I want to understand the idea.
File flashrom.c:
Patch Set #5, Line 1099: return -1;
Maybe you can add `msg_gerr` before returning. It seems like a big issue if the entire database of chips is absent.
File tests/selfcheck.c:
Patch Set #5, Line 80: /* unused */
But it is used two lines below?
flashchips = get_flashchips();
flashchips_size = get_flashchips_size();
Can this be immediately initialised? (and the same above). This is what non-test code is doing.
To view, visit change 75646. To unsubscribe, or for help writing mail filters, visit settings.