This doesn't seem like anybody has read this. It breaks the dummyflasher,
uses discouraged functions (like atoi()), didn't update the manpage...
Uploaded https://review.coreboot.org/c/flashrom/+/46536 for fixes.
Thanks for the immediate reaction! And sorry for the harsh words.
I'm sometimes too tense because I see the community cleaning up
behind such things. Really, much appreciate that you care about it
after merge :)
View Change
To view, visit change 44879. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iff266e151459561b126ecfd1c47420b385be1db2
Gerrit-Change-Number: 44879
Gerrit-PatchSet: 8
Gerrit-Owner: Namyoon Woo <namyoon@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Namyoon Woo <namyoon@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 19 Oct 2020 14:16:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment