Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File programmer.h:

  • Patch Set #1, Line 228: enable_flash_xxx

    Example: https://github.com/torvalds/linux/blob/fcadab740480e0e0e9fa9bd272acd409884d431a/Documentation/locking/spinlocks.rst

    Huh? that's documentation examples, I don't see there any `xxx` in an API?

    Also, the syntax alone makes it obvious that it's not a specific implementation
    that is called. Why introduce placeholders? Imagine I would have used outb_xxx,
    inb_xxx, outw_xxx, etc. in CB:52604. Would there be any benefit?

    I see the whole thing here as a usual command pattern. The function references
    are often called run() or execute(); doit() would work for me too. For me it's
    a chipset enable and what we do is run the chipset enable.

    NB. I think enable_flash_* is not a good name for these functions in general.

To view, visit change 52364. To unsubscribe, or for help writing mail filters, visit settings.