Thomas Heijligen submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Thomas Heijligen: Looks good to me, approved
jedec.c: Drop branching non-zero programmer_delay() operands

The programmer_delay() function is already tolerant upon zero
delay values and will simply just return with a NOP. Therefore
there is no need to branch.

Change-Id: Ic547669bb16e6ace4fe283e07345fc2d7075d63e
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/72692
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
---
M jedec.c
1 file changed, 23 insertions(+), 10 deletions(-)

diff --git a/jedec.c b/jedec.c
index 6ae767a..f9442ec 100644
--- a/jedec.c
+++ b/jedec.c
@@ -43,8 +43,7 @@
tmp1 = chip_readb(flash, dst) & 0x40;

while (i++ < 0xFFFFFFF) {
- if (delay)
- programmer_delay(flash, delay);
+ programmer_delay(flash, delay);
tmp2 = chip_readb(flash, dst) & 0x40;
if (tmp1 == tmp2) {
break;
@@ -203,8 +202,7 @@
* mode completely. Allow the chip to finish this before seeing a
* reset command.
*/
- if (probe_timing_enter)
- programmer_delay(flash, probe_timing_enter);
+ programmer_delay(flash, probe_timing_enter);
/* Reset chip to a clean slate */
if ((chip->feature_bits & FEATURE_RESET_MASK) == FEATURE_LONG_RESET) {
chip_writeb(flash, 0xAA, bios + ((shifted ? 0x2AAA : 0x5555) & mask));
@@ -215,8 +213,7 @@
programmer_delay(flash, 10);
}
chip_writeb(flash, 0xF0, bios + ((shifted ? 0x2AAA : 0x5555) & mask));
- if (probe_timing_exit)
- programmer_delay(flash, probe_timing_exit);
+ programmer_delay(flash, probe_timing_exit);

/* Issue JEDEC Product ID Entry command */
chip_writeb(flash, 0xAA, bios + ((shifted ? 0x2AAA : 0x5555) & mask));
@@ -226,8 +223,7 @@
if (probe_timing_enter)
programmer_delay(flash, 10);
chip_writeb(flash, 0x90, bios + ((shifted ? 0x2AAA : 0x5555) & mask));
- if (probe_timing_enter)
- programmer_delay(flash, probe_timing_enter);
+ programmer_delay(flash, probe_timing_enter);

/* Read product ID */
id1 = chip_readb(flash, bios + (0x00 << shifted));
@@ -257,8 +253,7 @@
programmer_delay(flash, 10);
}
chip_writeb(flash, 0xF0, bios + ((shifted ? 0x2AAA : 0x5555) & mask));
- if (probe_timing_exit)
- programmer_delay(flash, probe_timing_exit);
+ programmer_delay(flash, probe_timing_exit);

msg_cdbg("%s: id1 0x%02x, id2 0x%02x", __func__, largeid1, largeid2);
if (!oddparity(id1))

To view, visit change 72692. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic547669bb16e6ace4fe283e07345fc2d7075d63e
Gerrit-Change-Number: 72692
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged