Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Stefan Reinauer.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 25: Signed-off-by: roccochen@chromium.com <roccochen@chromium.org>
You currently have email repeated twice in sign off line, but this should be name and email, see the guide:
https://www.flashrom.org/dev_guide/development_guide.html#sign-off-procedure
I guess we missed this on previous patches, but let's start doing it right from now on. I think you can setup your name in git config.
To view, visit change 81356. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3b164ce4ae84bfd523fcd8be416c5d13183ed632
Gerrit-Change-Number: 81356
Gerrit-PatchSet: 2
Gerrit-Owner: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Gerrit-Attention: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-Attention: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Comment-Date: Wed, 27 Mar 2024 05:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment