Attention is currently required from: Thomas Heijligen, Peter Marheine.

View Change

2 comments:

• Patchset:

  • Patch Set #3:

    Peter, what is it that you use the Meson build for actually?
    Meson is generally not considered supported. It's a kludge to
    integrate libflashrom in fwupd and then got used for tests as
    well.

• File meson.build:

  • Patch Set #3, Line 357: error('RAW access is not available on non-x86 platforms. Disable the programmer which needs it. Use `meson build -Dpciutils=false -Dconfig_rayer_spi=false`')

    Well, the comment about ARM is not wrong. But I have to admit it's misleading
    when kept with the stub. Maybe just drop that one line.

    A relatively simple fix might be...

    An even simpler fix would be to drop Meson support. We shouldn't discuss what
    is simple, but what is the right thing to do.

To view, visit change 61198. To unsubscribe, or for help writing mail filters, visit settings.