Patch set 2:Code-Review +1

View Change

6 comments:

• File raiden_debug_spi.c:

  • Patch Set #2, Line 720: int

    This variable should be declared out of the loop, c.f. CB:38034

  • Patch Set #2, Line 726:

    Replace 8 spaces with a tab?

  • Patch Set #2, Line 782: status =

    return directly and drop the intermediate status var?

    Sounds good

  • Patch Set #2, Line 855: PACKET_ID_V2_RESPONSE_CONTINUE) {

    This fits on a single line, or is it very close to the limit?

  • Patch Set #2, Line 913: } else {

    How about "else if" here?

    Actually, I think we should wrap these into functions and error out if the version is invalid

  • Patch Set #2, Line 977: /* We were successful at performing the SPI transfer. */

    Refactoring note (not for this commit): This "else" could be moved to line 947 to drop one indentation level

To view, visit change 41533. To unsubscribe, or for help writing mail filters, visit settings.