Attention is currently required from: Aarya, Nikolai Artemiev, Peter Marheine.
View Change
1 comment:
Patchset:
Patch Set #6:
I am wondering, this path in ichspi (ich_get_region) is the same in Chrome OS, is it possible to do a few test runs on a device?
There are unit tests in the following patch, but they are implementing test version of get_flash_region and this changes the ich one.
Otherwise I have no other comments!
To view, visit change 82496. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ia0ca867aef33b598c2697fc264807fa5e29683ec
Gerrit-Change-Number: 82496
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Mon, 27 May 2024 10:41:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No