Attention is currently required from: Edward O'Callaghan, Evan Benn, Hsuan-ting Chen.

View Change

1 comment:

• File util/flashrom_tester/flashrom/src/cmd.rs:

  • Patch Set #3, Line 301: // TODO

    The flashrom CLI sets its own default flags, and we currently have no need for custom flags, so this […]

    Okay so just to check my understanding, the reason we need this here (even if empty) is because it is defined in `pub trait Flashrom` and now `cmd.rs` needs an implementation, even if empty? Can this no-op fn be removed from cmd.rs, or is it required?

    I am not sure whether we get votes from Ed and Evan, maybe not, I will try to finish review by myself, so that's why I am having questions :)

To view, visit change 79304. To unsubscribe, or for help writing mail filters, visit settings.