Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved
dediprog: Disable SPI_MASTER_NO_4BA_MODES for additional devices

The SPI_MASTER_NO_4BA_MODES is for SPI master not keeping the flash
powered between programming commands. Tests on the following devices
showed that the power is stable accross commands:

* SF100 protocol 2 V:6.5.03
* SF600 protocol 3 V:7.2.45

Change-Id: Iee0ba972245b9317ef86345432fec5fc32614888
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/44776
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
---
M dediprog.c
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dediprog.c b/dediprog.c
index c50e374..ac7d462 100644
--- a/dediprog.c
+++ b/dediprog.c
@@ -1267,7 +1267,8 @@
if (dediprog_standalone_mode())
return 1;

- if (dediprog_devicetype == DEV_SF100 && protocol() == PROTOCOL_V1)
+ if ((dediprog_devicetype == DEV_SF100) ||
+ (dediprog_devicetype == DEV_SF600 && protocol() == PROTOCOL_V3))
spi_master_dediprog.features &= ~SPI_MASTER_NO_4BA_MODES;

if (protocol() == PROTOCOL_V2)

To view, visit change 44776. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iee0ba972245b9317ef86345432fec5fc32614888
Gerrit-Change-Number: 44776
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged