Attention is currently required from: Simon Buhrow, Nico Huber, Aarya, Anastasia Klimchuk.

View Change

1 comment:

• File flashrom.c:

  • Patch Set #72, Line 1349: static int erase_by_layout

    I can do that, but then later do I have to again move back my implementation into flashrom. […]

    It would be my view to more your whole implementation into its own separate file. It seems pretty modular so atomically adding everything in one commit is logical and subsequent commits deal with the integration challenge of switching from old to new, preferably with one liner that can be trivially reverted.

    The `flashrom.c` kitchen sink should be broken up in any case and given your modular work this is a opportunity to advance that goal forwards at the same time rather than adding to the problem.

    `erasure_layout.c`, `flashrom_erasure.c`, just `flash_erasure.c` something like that?

To view, visit change 66104. To unsubscribe, or for help writing mail filters, visit settings.