[PATCH] buildrom: Update kconfig to recent version
See patch. The actual patch is buildrom_update_kconfig.patch.gz but that's huge and totally unreadable so I recommend reviewing buildrom_update_kconfig_makefile.patch That's the only change to the buildrom code itself, the rest is just replacing the whole scripts/kconfig/ dir with the new kconfig. I used the coreinfo kconfig/ with only a handful of string replacements a la s/coreinfo/buildrom/ so the diff to coreinfo's kconfig is tiny. I did some ad-hoc testing with this, tried various kconfig targets (menuconfig, xconfig, gconfig, ...) and various buildrom builds and it seems to work fine so far, but some more testing by others is highly appreciated. Thanks, Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
On 25/04/08 02:06 +0200, Uwe Hermann wrote:
See patch.
The actual patch is buildrom_update_kconfig.patch.gz but that's huge and totally unreadable so I recommend reviewing buildrom_update_kconfig_makefile.patch
That's the only change to the buildrom code itself, the rest is just replacing the whole scripts/kconfig/ dir with the new kconfig.
I used the coreinfo kconfig/ with only a handful of string replacements a la s/coreinfo/buildrom/ so the diff to coreinfo's kconfig is tiny.
I did some ad-hoc testing with this, tried various kconfig targets (menuconfig, xconfig, gconfig, ...) and various buildrom builds and it seems to work fine so far, but some more testing by others is highly appreciated.
+HOSTCC = gcc +HOSTCXX = g++ +HOSTCFLAGS := -I$(srck) -I$(objk) +HOSTCXXFLAGS := -I$(srck) -I$(objk) Can you move these to scripts/Build.settings, please? Thats the common repository for these sorts of things. In fact, HOSTCC is already there. Jordan
On Thu, Apr 24, 2008 at 06:22:00PM -0600, Jordan Crouse wrote:
On 25/04/08 02:06 +0200, Uwe Hermann wrote:
See patch.
The actual patch is buildrom_update_kconfig.patch.gz but that's huge and totally unreadable so I recommend reviewing buildrom_update_kconfig_makefile.patch
That's the only change to the buildrom code itself, the rest is just replacing the whole scripts/kconfig/ dir with the new kconfig.
I used the coreinfo kconfig/ with only a handful of string replacements a la s/coreinfo/buildrom/ so the diff to coreinfo's kconfig is tiny.
I did some ad-hoc testing with this, tried various kconfig targets (menuconfig, xconfig, gconfig, ...) and various buildrom builds and it seems to work fine so far, but some more testing by others is highly appreciated.
+HOSTCC = gcc +HOSTCXX = g++ +HOSTCFLAGS := -I$(srck) -I$(objk) +HOSTCXXFLAGS := -I$(srck) -I$(objk)
Can you move these to scripts/Build.settings, please? Thats the common repository for these sorts of things. In fact, HOSTCC is already there.
Not easily I think, these variables are used by kconfig internally, but scripts/Build.settings is (currently) only read after the 'make config' or 'make menuconfig' step so that likely won't work. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
On 25/04/08 02:46 +0200, Uwe Hermann wrote:
On Thu, Apr 24, 2008 at 06:22:00PM -0600, Jordan Crouse wrote:
On 25/04/08 02:06 +0200, Uwe Hermann wrote:
See patch.
The actual patch is buildrom_update_kconfig.patch.gz but that's huge and totally unreadable so I recommend reviewing buildrom_update_kconfig_makefile.patch
That's the only change to the buildrom code itself, the rest is just replacing the whole scripts/kconfig/ dir with the new kconfig.
I used the coreinfo kconfig/ with only a handful of string replacements a la s/coreinfo/buildrom/ so the diff to coreinfo's kconfig is tiny.
I did some ad-hoc testing with this, tried various kconfig targets (menuconfig, xconfig, gconfig, ...) and various buildrom builds and it seems to work fine so far, but some more testing by others is highly appreciated.
+HOSTCC = gcc +HOSTCXX = g++ +HOSTCFLAGS := -I$(srck) -I$(objk) +HOSTCXXFLAGS := -I$(srck) -I$(objk)
Can you move these to scripts/Build.settings, please? Thats the common repository for these sorts of things. In fact, HOSTCC is already there.
Not easily I think, these variables are used by kconfig internally, but scripts/Build.settings is (currently) only read after the 'make config' or 'make menuconfig' step so that likely won't work.
Okay, then kill off the HOSTCC in Build.settings - this is very unfortunate, I would much rather keep this sort of thing out of the Makefile proper. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.
On Thu, Apr 24, 2008 at 08:52:48PM -0600, Jordan Crouse wrote:
+HOSTCC = gcc +HOSTCXX = g++ +HOSTCFLAGS := -I$(srck) -I$(objk) +HOSTCXXFLAGS := -I$(srck) -I$(objk)
Can you move these to scripts/Build.settings, please? Thats the common repository for these sorts of things. In fact, HOSTCC is already there.
Not easily I think, these variables are used by kconfig internally, but scripts/Build.settings is (currently) only read after the 'make config' or 'make menuconfig' step so that likely won't work.
Okay, then kill off the HOSTCC in Build.settings - this is very unfortunate, I would much rather keep this sort of thing out of the Makefile proper.
Alternatively we could have them in scripts/kconfig/Makefile (in addition) and leave Build.settings as is, so that HOSTCC will be overridden by that after the 'menuconfig' check. Not sure if there are issues with that. Will test later. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
On Thu, Apr 24, 2008 at 6:06 PM, Uwe Hermann <uwe@hermann-uwe.de> wrote:
See patch.
The actual patch is buildrom_update_kconfig.patch.gz but that's huge and totally unreadable so I recommend reviewing buildrom_update_kconfig_makefile.patch
That's the only change to the buildrom code itself, the rest is just replacing the whole scripts/kconfig/ dir with the new kconfig.
I used the coreinfo kconfig/ with only a handful of string replacements a la s/coreinfo/buildrom/ so the diff to coreinfo's kconfig is tiny.
I did some ad-hoc testing with this, tried various kconfig targets (menuconfig, xconfig, gconfig, ...) and various buildrom builds and it seems to work fine so far, but some more testing by others is highly appreciated.
It doesn't change the behavior of my favorite builds. It does get rid of the invalid value warnings. In Makefile, you can remove the declaration of KCONFIG_DIR, since you deleted all other references to it. Acked-by: Myles Watson <mylesgw@gmail.com> Thanks, Myles
Thanks, Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-- coreboot mailing list coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Tue, Jul 01, 2008 at 03:35:05PM -0600, Myles Watson wrote:
It doesn't change the behavior of my favorite builds. It does get rid of the invalid value warnings.
In Makefile, you can remove the declaration of KCONFIG_DIR, since you deleted all other references to it.
Acked-by: Myles Watson <mylesgw@gmail.com>
Thanks, r210. Will look into KCONFIG_DIR (and test it). Thanks, Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
participants (3)
-
Jordan Crouse -
Myles Watson -
Uwe Hermann