[LinuxBIOS] [PATCH] Add includes to it8712f/superio.c

[Jon Dufresne]

Added two includes to it8712f/superio.c, the file will not compile without them

Signed-off-by: Jon Dufresne 
---

[Uwe Hermann]

Hi,

sorry for the delay.

On Mon, Nov 20, 2006 at 05:17:25PM -0500, Jon Dufresne wrote:
> Added two includes to it8712f/superio.c, the file will not compile without 
> them
> Signed-off-by: Jon Dufresne
> Index: src/superio/ite/it8712f/superio.c
>
> --- src/superio/ite/it8712f/superio.c	(revision 2498)
> +++ src/superio/ite/it8712f/superio.c	(working copy)
> @@ -18,6 +18,8 @@
> Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
>
> */
>
> +#include <device/device.h>
> +#include <device/pnp.h>
>  #include <uart8250.h>
>  #include <pc80/keyboard.h>
>  #include "chip.h"

All other ITE Super I/Os will have the same problem, I guess. I probably
didn't notice this as the #includes are drawn in in some other file,
too, on the mainboard code I used.

Can you crate a patch which fixes all of the ITEs, adding all required
#includes to all files (mostly superio.c and chip.h)?

Please also note, that I didn't test any of the ITE chips other than
IT8671F, so they may or may not work. If you could test serial output, that
would be very nice. Anything other than serial output (floppy, keyboard,
whatever) I haven't tested _at all_, and partly there's not even any
code written for that, yet (but it's not too hard)...

Uwe.

[Jon Dufresne]

Using the available superio I have seen early serial output with an
ite it8712f chip. It is the only chip I have and therefore can
confirm. As I get more to devices to work I'll let you know.

I have attached a diff fixing all ite includes. Do you normally prefer
an attachment or that I paste the diff in the email? You mentioned
adding includes to chip.h, however this file did not need
modifications for me and after looking at it, I don't think it needs
additional includes for the code contained in it.

-Jon

On 11/26/06, Uwe Hermann  wrote:
> Hi,
>
> sorry for the delay.
>
> On Mon, Nov 20, 2006 at 05:17:25PM -0500, Jon Dufresne wrote:
> > Added two includes to it8712f/superio.c, the file will not compile without
> > them
> > Signed-off-by: Jon Dufresne
> > Index: src/superio/ite/it8712f/superio.c
> >
> > --- src/superio/ite/it8712f/superio.c (revision 2498)
> > +++ src/superio/ite/it8712f/superio.c (working copy)
> > @@ -18,6 +18,8 @@
> > Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> >
> > */
> >
> > +#include <device/device.h>
> > +#include <device/pnp.h>
> >  #include <uart8250.h>
> >  #include <pc80/keyboard.h>
> >  #include "chip.h"
>
> All other ITE Super I/Os will have the same problem, I guess. I probably
> didn't notice this as the #includes are drawn in in some other file,
> too, on the mainboard code I used.
>
> Can you crate a patch which fixes all of the ITEs, adding all required
> #includes to all files (mostly superio.c and chip.h)?
>
> Please also note, that I didn't test any of the ITE chips other than
> IT8671F, so they may or may not work. If you could test serial output, that
> would be very nice. Anything other than serial output (floppy, keyboard,
> whatever) I haven't tested _at all_, and partly there's not even any
> code written for that, yet (but it's not too hard)...
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (GNU/Linux)
>
> iD8DBQFFaczrXdVoV3jWIbQRApD3AJ9/8cF0a1X7d/RHvKLgc4cT9VSXKgCgiDiK
> 8kAUYJMb5GdXuxsjWpONTmE=
> =eSfo
> -----END PGP SIGNATURE-----

[LinuxBIOS] [PATCH] Add missing includes to ITE Super I/Os.

[Uwe Hermann]

Add missing #includes to some ITE Super I/O files.

Signed-off-by: Jon Dufresne 
Signed-off-by: Uwe Hermann

---

On Sun, Nov 26, 2006 at 02:24:00PM -0500, Jon Dufresne wrote:
> Using the available superio I have seen early serial output with an
> ite it8712f chip.

OK, great!
> I have attached a diff fixing all ite includes. Do you normally prefer
> an attachment or that I paste the diff in the email?

I personally don't care. For non-trivial patches we should definately use
the issue tracker, though (http://tracker.linuxbios.org/trac/LinuxBIOS/).
> You mentioned
> adding includes to chip.h, however this file did not need
> modifications for me and after looking at it, I don't think it needs
> additional includes for the code contained in it.

I think it should have an #include for 'struct chip_operations', and I
also added an #include for 'device_t' in *_early_*.c.

Uwe.