[PATCH]Use cbfs-files-y for normal file additions

[Georgi, Patrick]

Hi,

we currently have special cases for VGABIOS, Intel MBI and
splashscreens. Use cbfs-files-y instead, which provides a canonical way
for adding raw files to CBFS.

Question is, if we should drop these Kconfig options entirely and let
the user handle these entries in the board's Makefile.inc?

Signed-off-by: Patrick Georgi

[Peter Stuge]

Georgi, Patrick wrote:
> Question is, if we should drop these Kconfig options entirely and let
> the user handle these entries in the board's Makefile.inc?

Sometimes the files come from chipset though.
> Signed-off-by: Patrick Georgi

With the fix below:

Acked-by: Peter Stuge
> +++ b/src/arch/x86/Makefile.inc
> @@ -117,6 +96,18 @@ endif
>    @printf "    CBFSPRINT  $(subst $(obj)/,,$(@))\n\n"
>    $(CBFSTOOL) $@ print
>
> +cbfs-files-$(CONFIG_VGA_BIOS) += pci$(call strip_quotes,$(CONFIG_VGA_BIOS_ID)).rom
> +pci$(CONFIG_VGA_BIOS_ID)-file := $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE))
> +pci$(CONFIG_VGA_BIOS_ID)-type := optionrom

These last two need .rom as well, right?

//Peter

[Patrick Georgi]

Am 29.01.2011 11:22, schrieb Peter Stuge:
> > +cbfs-files-$(CONFIG_VGA_BIOS) += pci$(call strip_quotes,$(CONFIG_VGA_BIOS_ID)).rom
> > +pci$(CONFIG_VGA_BIOS_ID)-file := $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE))
> > +pci$(CONFIG_VGA_BIOS_ID)-type := optionrom
>
> These last two need .rom as well, right?

You're right. I also replicated the strip_quotes call to the two later
lines.

Committed as r6320

Patrick