[RFC] Gerrit: Please enable sticky scores for trivial rebases and no code changes

[Paul Menzel]

Dear coreboot folks,

on IRC I was told, developers won’t update or fix commit messages as
long as it means +2 scores are removed.

Luckily Gerrit supports that [2].

A useful feature on labels is the possibility to automatically
        copy scores forward to new patch sets if it was a trivial rebase
        or if there was no code change (e.g. only the commit message was
        edited).

I propose to enable these two features.

If nobody opposes until next Monday, September 8th, it’d be great if the
two config parameters below could be set to true.

1. label.Label-Name.copyAllScoresOnTrivialRebase [3]
2. label.Label-Name.copyAllScoresIfNoCodeChange [4]

Thanks,

Paul

[1] http://review.coreboot.org/Documentation/intro-project-owner.html#labels
[2] http://review.coreboot.org/Documentation/intro-project-owner.html#labels
[3] http://review.coreboot.org/Documentation/config-labels.html#label_copyAllSco...
[4] http://review.coreboot.org/Documentation/config-labels.html#label_copyAllSco...

[Vadim Bendebury]

Note that the version of gerrit used for chromeos allows editing the
commit message through the web interface, no need to re-upload the
patch, and the scores are kept.

Not sure if this is available in the coreboot gerrit though.

--vb

On Wed, Sep 3, 2014 at 12:39 AM, Paul Menzel
 wrote:
> Dear coreboot folks,
>
> on IRC I was told, developers won’t update or fix commit messages as
> long as it means +2 scores are removed.
>
> Luckily Gerrit supports that [2].
>     A useful feature on labels is the possibility to automatically
>     copy scores forward to new patch sets if it was a trivial rebase
>     or if there was no code change (e.g. only the commit message was
>     edited).
>
> I propose to enable these two features.
>
> If nobody opposes until next Monday, September 8th, it’d be great if the
> two config parameters below could be set to true.
> label.Label-Name.copyAllScoresOnTrivialRebase [3]
> label.Label-Name.copyAllScoresIfNoCodeChange [4]
>
> Thanks,
>
> Paul
>
> [1] http://review.coreboot.org/Documentation/intro-project-owner.html#labels
> [2] http://review.coreboot.org/Documentation/intro-project-owner.html#labels
> [3] http://review.coreboot.org/Documentation/config-labels.html#label_copyAllSco...
> [4] http://review.coreboot.org/Documentation/config-labels.html#label_copyAllSco...

[RFC] Gerrit: Please enable sticky scores for trivial rebases and no code changes

[Patrick Georgi]

Am 2014-09-03 09:39, schrieb Paul Menzel:
> If nobody opposes until next Monday, September 8th, it’d be great if 
> the
> two config parameters below could be set to true.
> label.Label-Name.copyAllScoresOnTrivialRebase
> label.Label-Name.copyAllScoresIfNoCodeChange

Thanks for your investigation. Given the positive response I activated 
them.

Patrick