In my pipeline is something more infrastructural, something different from what I usually do -
I am converting early serial code for Winbond W83977TF from code included in romstage to compiled unit to be linked into romstage.
13 boards use this superio, some apparently still not converted to CAR (including one Intel server board). I have yet to complete running abuild on my change. Should I let it break when I submit it for review given earlier buzz suggesting we leave non-CAR boards behind?
The reason I'm doing this is I want to do this for ITE IT8705F, which happens to have no board using it at the moment, but I want to test this approach on a board that I can boot test right now. Enter the P2B-LS and W83977TF. If this proof of concept works, we can start this conversion one superio at a time and nail down one more goal of the infrastructure refactoring.
Thoughts and comments?
On 02/28/2011 08:00 PM, Keith Hui wrote:
given earlier buzz suggesting we leave non-CAR boards behind?
There was no buzz. Just an idea I sent to the list that no one seemed interested in :(.
To try to answer your question, switching early_serial from included to linked is exactly what I tried to do with the F81865F. You know my opinion on the matter, but I can't speak for everyone. If you just want your patch to be discussed, I guess it's OK to leave some boards broken. If you want it included, and it breaks non-CAR, you will have to check with the others.
I hope this answers your question.