New patch to review for coreboot: 3344880 Fix the DIMM slot mapping

[Rudolf Marek]

Rudolf Marek ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/449

-gerrit

commit 3344880a57c8e1083f5580d6990885f3b976ae6c
Author: Rudolf Marek 
Date:   Wed Nov 23 00:23:43 2011 +0100

Fix the DIMM slot mapping

Fix the DIMM mappings, channel 0 is "B" on board,
    and secondary channel is on 0x51,0x53

Change-Id: I8c49c4efb90a4297aaea0be2159435dadab9ac0a
    Signed-off-by: Rudolf Marek 
---
 src/mainboard/asus/a8v-e_se/romstage.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/asus/a8v-e_se/romstage.c b/src/mainboard/asus/a8v-e_se/romstage.c
index 4e08859..4193452 100644
--- a/src/mainboard/asus/a8v-e_se/romstage.c
+++ b/src/mainboard/asus/a8v-e_se/romstage.c
@@ -147,10 +147,10 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
    static const uint16_t spd_addr[] = {
    	// Node 0
    	DIMM0, DIMM2, 0, 0,
-		DIMM1, DIMM3, 0, 0,
+		0, 0, 0, 0,
    	// Node 1
-		DIMM4, DIMM6, 0, 0,
-		DIMM5, DIMM7, 0, 0,
+		DIMM1, DIMM3, 0, 0,
+		0, 0, 0, 0,
    };
    unsigned bsp_apicid = 0;
    int needs_reset = 0;

New patch to review for coreboot: 3344880 Fix the DIMM slot mapping

[Paul Menzel]

Am Mittwoch, den 23.11.2011, 00:26 +0100 schrieb Rudolf Marek:
> Rudolf Marek ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/449
>
> -gerrit
>
> commit 3344880a57c8e1083f5580d6990885f3b976ae6c
> Author: Rudolf Marek 
> Date:   Wed Nov 23 00:23:43 2011 +0100
> Fix the DIMM slot mapping

Maybe prefix that with »asus a8v-e se: …«.
> Fix the DIMM mappings, channel 0 is "B" on board,
> and secondary channel is on 0x51,0x53

I guess you have tested that. This would make approving this patch much
easier if you add that.
> Change-Id: I8c49c4efb90a4297aaea0be2159435dadab9ac0a
> Signed-off-by: Rudolf Marek <[e-mail]>

[…]

Thanks,

Paul